Split CI checks from Netlify previews#97
Merged
Conversation
Run tests and visual regression in GitHub Actions, publish production from GitHub Actions after they pass, and leave Netlify deploy previews build-only.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Restrict the default GitHub Actions token to read-only repository contents for CI and Netlify deploy jobs.
Keep the workflow token read-only for repository contents, but restore status write access for the visual regression action.
Run visual regression only for pull requests and master pushes so Lost Pixel does not receive separate push and pull_request uploads for the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Previously, failing typechecks would prevent branch deploy previews. Failed production deploy reasons were primarily due to the test suite, and not visible from GitHub.
Move the primary checking responsibility to GitHub Actions.
Changes